Page MenuHomePhabricator

Edge case in command parser for redirection
Closed, ResolvedPublic

Description

Looks like we're doing something hinky with the space after a redirect command.

#?Pre or postSpacedLinkedCommandResult
1PreYesYes!link > ChanServ [[f]]ChanServ [[f]]: https://en.wikipedia.org/wiki/f
2PreYesNo!link > ChanServ fChanServ f: https://en.wikipedia.org/wiki/f
3N/AYesCachedLorem ipsum [[WP:CORP]] Blah blah padding text !link > AntiComposite AntiComposite : https://en.wikipedia.org/wiki/WP:CORP
4PreNoYes!link >ChanServ [[f]]ChanServ: https://en.wikipedia.org/wiki/f
5PreNoNo!link >ChanServ fChanServ: https://en.wikipedia.org/wiki/f
6N/ANoCached[[foobar]] !link >stwalkersterstwalkerster: https://en.wikipedia.org/wiki/foobar
7PostYesYes!link [[WP:CORP]] > Zppix Zppix : https://en.wikipedia.org/wiki/WP:CORP
8PostYesNo!link goo > ChanServChanServ: https://en.wikipedia.org/wiki/goo
9PostNoYes!link [[zoo]] >ChanServChanServ: https://en.wikipedia.org/wiki/zoo
10PostNoNo!link loo >ChanServChanServ: https://en.wikipedia.org/wiki/loo

Revisions and Commits

Event Timeline

This looks related to the ignored tests in LegacyCommandParser, specifically against the FindRedirection method which appears to be designed to take everything after the > as a redirection target.

stwalkerster claimed this task.
Diffusion added a commit: Restricted Diffusion Commit.Jan 8 2017, 1:15 AM