Page MenuHomePhabricator

Review status: "!draft Draft:Example"
Closed, ResolvedPublic

Description

Add a new command that reports the current status of a provided AfC draft.

This command should be protected under the I flag.

Logic

  1. Check for page existence. If it doesn't exist, try to fuzzy-match to an existing page - add Draft: if it doesn't exist, differentiate by case, etc. If more than one found, ask for clarification.
  2. Pull all the categories the page is in. Changes to MediaWikiApi Lib will be needed for this
  3. Check the categories:
    1. if in Category:Pending AfC submissions being reviewed now, then the article is supposedly in the middle of being reviewed and we should report this.
    2. if in Category:Pending AfC submissions, it's supposed to be in the review queue. See if we can pull the sortkey from the page to check - C or M probably means something is messed up or it's in the middle of acceptance and we should just report an error. R is probably an error as we should have already handled this. D should probably be raised as an info point, need to check what other categories a draft is in but otherwise it should be fine to continue with whatever else we find. P should contain everything else. There should also be "by date" categories which tell us how long a page has been in the queue for which might be useful to include in a message if we can sanely parse that out. Send a message saying something like Review waiting for {duration}, please be patient. This may take more than {expected duration}. There are {totaldrafts} drafts currently waiting for review.
    3. if in Category:Draft AfC submissions, it's not currently submitted for review, and report this.
    4. if in one of the rejected categories below, do something fancy with it reporting a brief summary of why it was rejected.
    5. if in one of the declined categories below, do something fancy with it reporting a brief summary of why it was declined.

Things to consider

  • As Helpmebot is inherently multi-wiki and multi-channel, we probably need a way of either disabling this when not in an enwiki channel.
  • Changes to the categories and messages - this shouldn't be hard-coded into the bot in case things change.
  • Figure out how to pull the oldest draft
  • Pulling the total number of drafts can be done with the existing command. It (hopefully) pulls from MediaWikiApi Lib anyway, so just do the same sort of call
  • Performance - keep an eye on the number of API calls we're doing, as it might add up and impact performance.

Rejection categories

Decline categories

Event Timeline

swalker triaged this task as Normal priority.Apr 29 2019, 10:46 AM
swalker changed the visibility from "Custom Policy" to "Public (No Login Required)".
swalker removed a project: Restricted Project.
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Aug 19 2019, 12:16 AM

@ToBeFree - this is what I've got so far:

23:39:11 <@Oresrian> !draft Draft:Aaruush
23:39:13 <+HMBDebug> [[Draft:Aaruush]] has been declined as an advertisement, and as non-notable.
23:39:16 <@Oresrian> !draft Henrietta Bussell
23:39:17 <+HMBDebug> [[Henrietta Bussell]] has been submitted for review.
23:39:17 <+HMBDebug> This submission is in the article namespace.
23:39:19 <@Oresrian> !draft Draft:GrapheneOS
23:39:21 <+HMBDebug> [[Draft:GrapheneOS]] has been submitted for review.
23:39:21 <+HMBDebug> This draft has been also been declined with a custom reason, and as lacking reliable third-party sources.
23:39:26 <@Oresrian> !draft Draft:Lenny Mendonca
23:39:28 <+HMBDebug> [[Draft:Lenny Mendonca]] has been submitted for review.
23:39:28 <+HMBDebug> This draft has been also been rejected as being not sufficiently notable for inclusion in Wikipedia.
23:39:29 <+HMBDebug> This draft has been also been declined as needing to be merged, and as a non-notable biography.
23:39:47 <@Oresrian> !draft Draft:Lakshmi Vijay
23:39:49 <+HMBDebug> [[Draft:Lakshmi Vijay]] has been rejected as being not sufficiently notable for inclusion in Wikipedia.
23:39:49 <+HMBDebug> This draft has been also been declined as lacking reliable third-party sources, as a non-notable biography, and as a non-notable musical topic.
23:39:58 <@Oresrian> !draft Draft:/r/Atheism
23:40:00 <+HMBDebug> [[Draft:/r/Atheism]] has been rejected as being not sufficiently notable for inclusion in Wikipedia.

Still on my todo list:

  • fuzzy search (probably not going to be done in the first release)
  • checks for duplication of an existing article
  • checks on the sortkey for Category:Pending AfC submissions
  • retrieving the date/age of the submission and associated predictions based on that

@stwalkerster , I'm very impressed. This looks awesome already. Thank you very much! :)

stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 8 2019, 10:45 PM
ToBeFree renamed this task from !reviewstatus Draft:Example to Review status: "!draft Draft:Example".Oct 9 2019, 5:32 PM

Speedy deletion tags should override any other message: If something is about to be speedily deleted, all other statuses are irrelevant

Articles currently under review are incorrectly displayed as "has been submitted for review."

stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 10 2019, 12:21 AM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 10 2019, 10:53 PM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 11 2019, 12:35 AM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 11 2019, 9:54 PM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 11 2019, 10:31 PM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 12 2019, 1:33 AM
stwalkerster mentioned this in Unknown Object (Diffusion Commit).Oct 12 2019, 1:52 AM
stwalkerster claimed this task.