Page MenuHomePhabricator

!acccount doesn't differentiate between tool users and tool admin
Closed, ResolvedPublic

Description

This is likely due to the move to user roles within ACC as part of newinternal.


Notes from IRC:

16:36:33 <+stw> It used to be the case that the ACC user table had a "status" column which changed between "User"/"Admin"/"Suspended"/etc. That's reflected on the API https://accounts.wmflabs.org/api.php?action=count&user=stwalkerster
16:37:19 <+stw> However, since newinternal, "User" and "Admin" have been replaced with a single "Active" value, as rights are conferred by roles, rather than by the user's status
16:37:33 <+stw> The roles aren't exposed on the ACC API, so Helpmebot's consuming it wrong
16:38:12 <+stw> Either you can take the easy option in Helpmebot only and see if any of the admin values are non-zero, and report the admin stats if any are non-zero
16:38:25 <+stw> Or you can expose the roles in ACC, then change Helpmebot to adapt to the new API definition
16:39:56 <+stw> https://github.com/helpmebot/helpmebot/blob/master/src/Helpmebot.AccountCreations/Commands/AccCountCommand.cs and https://github.com/enwikipedia-acc/waca/blob/master/includes/API/Actions/CountAction.php are relevant starting points