Page MenuHomePhabricator
Create Task
Maniphest T325

Unknown error during rate limit processing
Closed, ResolvedPublic
Actions

Description

2016-01-25 01:53:58,241 [10] DEBUG Default.NetworkClient.Inbound [(null)] - :ChanServ!ChanServ@services. JOIN ##Manishearth * :Channel Services

2016-01-25 01:53:58,241 [10] INFO Default.IrcClient [(null)] - Seen ChanServ!@ join channel ##Manishearth.

2016-01-25 01:53:58,246 [10] ERROR Helpmebot.Services.JoinMessageService [(null)] - Unknown error during rate limit processing.
System.ArgumentNullException: Argument cannot be null.
Parameter name: key

at System.Collections.Generic.Dictionary`2[System.String,NHibernate.Linq.Tuple`2[System.DateTime,System.Int32]].ContainsKey (System.String key) [0x00000] in <filename unknown>:0 
at Helpmebot.Services.JoinMessageService.RateLimit (System.String hostname, System.String channel) [0x00000] in <filename unknown>:0

Created: Tue, 16 Feb 2016 19:10:47 GMT
Last Updated: Mon, 22 Feb 2016 21:29:24 GMT

Details

External Reference
HMB-169

Event Timeline

stwalkerster created this task.Oct 25 2016, 1:14 AM
• Jenkins added a subscriber: • Jenkins.Oct 25 2016, 1:14 AM

jenkins wrote at Tue, 16 Feb 2016 20:17:34 GMT:

SUCCESS: Integrated in !https://jenkins.stwalkerster.co.uk/images/16x16/blue.png! [helpmebot-release #187|https://jenkins.stwalkerster.co.uk/job/helpmebot-release/187/]
HMB-169 Tidy up rate limit error handling a little bit (stwalkerster: [7e992671e68f183e11d62b9601a0f4c11764c574|https://github.com/helpmebot/helpmebot/commit/7e992671e68f183e11d62b9601a0f4c11764c574])

  • src/Helpmebot.Tests/Helpmebot.Tests.csproj
  • src/Helpmebot/Services/JoinMessageService.cs
  • src/Helpmebot.Tests/Helpmebot.Tests.csproj.DotSettings
  • src/Helpmebot.Tests/IRC/IrcClientTests.cs
  • src/Helpmebot/Legacy/Commands/Helper.cs
  • src/Helpmebot/Helpmebot.csproj.DotSettings
stwalkerster added a comment.Oct 25 2016, 1:14 AM

stwalkerster wrote at Mon, 22 Feb 2016 20:07:21 GMT:

OK, I think the problem here is that ChanServ is added via a reply to NAMES, as a skeleton and not as a real user. The real user is then getting blatted out by the cache load (which pulls in stuff like account information too).

Eurgh.

• Jenkins added a comment.Oct 25 2016, 1:14 AM

jenkins wrote at Mon, 22 Feb 2016 20:20:12 GMT:

SUCCESS: Integrated in !https://jenkins.stwalkerster.co.uk/images/16x16/blue.png! [helpmebot-release #189|https://jenkins.stwalkerster.co.uk/job/helpmebot-release/189/]
another attempt at HMB-169 (stwalkerster: [152a7d4096e7f17bce2e2a742be19db0fbb1c361|https://github.com/helpmebot/helpmebot/commit/152a7d4096e7f17bce2e2a742be19db0fbb1c361])

  • src/Helpmebot.Tests/IRC/Model/IrcUserTests.cs
  • src/Helpmebot/IRC/IrcClient.cs
  • src/Helpmebot/IRC/Model/IrcUser.cs
  • src/Helpmebot.Tests/IRC/IrcClientTests.cs
• Jenkins added a comment.Oct 25 2016, 1:14 AM

jenkins wrote at Mon, 22 Feb 2016 21:29:24 GMT:

SUCCESS: Integrated in !https://jenkins.stwalkerster.co.uk/images/16x16/blue.png! [helpmebot-release #191|https://jenkins.stwalkerster.co.uk/job/helpmebot-release/191/]
HMB-169 missed one skeleton fleshing, and 'tis the important one (stwalkerster: [cbc239d893e9aa7b105c90a273e304a139d02bdc|https://github.com/helpmebot/helpmebot/commit/cbc239d893e9aa7b105c90a273e304a139d02bdc])

  • src/Helpmebot.Tests/IRC/IrcClientTests.cs
  • src/Helpmebot/IRC/IrcClient.cs
stwalkerster moved this task from Backlog to Bugs on the Helpmebot board.Jan 6 2017, 8:15 PM
stwalkerster closed this task as Resolved.Jan 6 2017, 8:49 PM
• import-bot changed the edit policy from "All Users" to "Custom Policy".Feb 3 2017, 10:57 AM
stwalkerster changed the edit policy from "Custom Policy" to "Custom Policy".Jan 30 2018, 2:11 PM
stwalkerster removed a subscriber: • Jenkins.Jan 30 2018, 10:06 PM
stwalkerster.co.uk · helpmebot.org.uk · eyeinthesky.im · Phabricator · TeamCity · Nexus · Cloud