Page MenuHomePhabricator
Create Task
Maniphest T248

Make newinternal tests work even if there is no internet connectivity
Closed, ResolvedPublic
Actions

Description

Currently, there are two places where tests query the API. We should hard-code responses using mocking to prevent this, per good test practice. Example log with internet disabled:

Traveler:waca Matthew$ /Applications/XAMPP/xamppfiles/bin/php ~/phpunit-4.5.0.phar 
PHPUnit 4.5.0 by Sebastian Bergmann and contributors.

Configuration read from /Applications/XAMPP/xamppfiles/htdocs/waca/phpunit.xml.dist

F....E.............................................I....E........ 65 / 92 ( 70%)
....................II.....

Time: 276 ms, Memory: 7.75Mb

There were 2 errors:

1) Waca\Tests\IdentificationVerifierTest::testApiReturnsExpectedResults
Waca\Exceptions\CurlException: Remote request failed with error Failed to connect to 208.80.154.224: Host is down

/Applications/XAMPP/xamppfiles/htdocs/waca/includes/Helpers/HttpHelper.php:65
/Applications/XAMPP/xamppfiles/htdocs/waca/includes/IdentificationVerifier.php:168
/Applications/XAMPP/xamppfiles/htdocs/waca/tests/includes/IdentificationVerifierTest.php:53

2) Waca\Tests\Validation\RequestValidationHelperTest::testValidateGoodName
file_get_contents(https://en.wikipedia.org/w/api.php?action=query&list=users&ususers=TestName&format=php): failed to open stream: Host is down

/Applications/XAMPP/xamppfiles/htdocs/waca/includes/Validation/RequestValidationHelper.php:223
/Applications/XAMPP/xamppfiles/htdocs/waca/includes/Validation/RequestValidationHelper.php:71
/Applications/XAMPP/xamppfiles/htdocs/waca/tests/includes/Validation/RequestValidationHelperTest.php:58

--

There was 1 failure:

1) Warning
No tests found in class "CountActionTest".
                                                                  
FAILURES!                                                         
Tests: 92, Assertions: 273, Failures: 1, Errors: 2, Incomplete: 3.

(Ignore "CountActionTest" failure, I was implementing that test at the time I saved this log)

Event Timeline

matthewrbowker created this task.Sep 1 2016, 12:58 AM
matthewrbowker created this object in space S1 Default.
stwalkerster closed this task as Resolved.Sep 22 2016, 8:21 PM
stwalkerster claimed this task.
stwalkerster triaged this task as Normal priority.
stwalkerster added a subscriber: stwalkerster.

@matthewrbowker - I "fixed" the ID verifier test by making it skip when it can't contact meta; I'm hesitant to mock out the web request since I want to make sure that this code can deal with the potentially changing page on meta.

I know this is technically an integration test that we should be running with an integration test suite, but until we get a couple more "unit" tests that are actually integration tests, we might as well keep them as special cases here.

RequestValidationHelperTest::testValidateGoodName doesn't exist in my branch, so I suspect this is one of the tests you've added, or a test I've removed and forgotten about - we should probably sync up at some point soon.

• import-bot changed the edit policy from "All Users" to "Custom Policy".Feb 3 2017, 10:57 AM
stwalkerster changed the edit policy from "Custom Policy" to "Custom Policy".Jan 30 2018, 2:11 PM
stwalkerster.co.uk · helpmebot.org.uk · eyeinthesky.im · Phabricator · TeamCity · Nexus · Cloud